Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2252#discussion_r194479546
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java
---
@@ -56,7 +57,8 @@ public SafeVariableLengthDimensionDataChunkStore(boolean
isInvertedIndex, int nu
* @param invertedIndexReverse inverted index reverse to be stored
* @param data data to be stored
*/
- @Override public void putArray(final int[] invertedIndex, final int[]
invertedIndexReverse,
+ @Override
+ public void putArray(final int[] invertedIndex, final int[]
invertedIndexReverse,
--- End diff --
@xuchuanyin In Case of varchar column I think we will not be able to store
complete data in single byte array as it may overflow, in case of short it is
fine as maximum it will be of 32000(max number of bytes in each value) *
32000(number of records in page) + 64000(length for each value in a page), so
it will be 1024064000 value and as maximum u can create an array of integer max
value so it is fine, but in varchar case length of each value can be maximum of
Integer max it self so we will not be able to store in single byte array. This
handling is required in both data loading and query.
---
