Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2334#discussion_r197669862
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java
---
@@ -171,134 +170,89 @@ else if
(colType.equals(DecimalType.createDecimalType(carbondataColumnHandle.get
* @return
*/
static Expression parseFilterExpression(TupleDomain<ColumnHandle>
originalConstraint) {
- ImmutableList.Builder<Expression> filters = ImmutableList.builder();
Domain domain;
+ Expression finalFilters = null;
--- End diff --
Can you provide comments to explain the below Expression? and why
colExpression need put "final"?
Expression finalFilters = null;
final Expression colExpression = new ColumnExpression(cdch.getColumnName(),
coltype);
Expression colValueExpression = null;
Expression rangeExpression = null;
---
