Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2334#discussion_r197721852
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java
 ---
    @@ -171,134 +170,89 @@ else if 
(colType.equals(DecimalType.createDecimalType(carbondataColumnHandle.get
        * @return
        */
       static Expression parseFilterExpression(TupleDomain<ColumnHandle> 
originalConstraint) {
    -    ImmutableList.Builder<Expression> filters = ImmutableList.builder();
     
         Domain domain;
    +    Expression finalFilters = null;
    --- End diff --
    
    1. I mean, please put these detail explanation inside the code in your pr
    2. colExpression, just column's name and data type, why may change ? 



---

Reply via email to