Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2401#discussion_r198440267
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3041,24 +3041,30 @@ public static String
getBlockId(AbsoluteTableIdentifier identifier, String fileP
* @param mainTableProperties
*/
public static void setLocalDictColumnsToWrapperSchema(List<ColumnSchema>
columns,
- Map<String, String> mainTableProperties) {
- String isLocalDictEnabledForMainTable =
-
mainTableProperties.get(CarbonCommonConstants.LOCAL_DICTIONARY_ENABLE);
- String localDictIncludeColumnsOfMainTable =
-
mainTableProperties.get(CarbonCommonConstants.LOCAL_DICTIONARY_INCLUDE);
- String localDictExcludeColumnsOfMainTable =
-
mainTableProperties.get(CarbonCommonConstants.LOCAL_DICTIONARY_EXCLUDE);
+ Map<String, String> mainTableProperties, String
isLocalDictEnabledForMainTable) {
String[] listOfDictionaryIncludeColumns = null;
String[] listOfDictionaryExcludeColumns = null;
+ String localDictIncludeColumns =
+
mainTableProperties.get(CarbonCommonConstants.LOCAL_DICTIONARY_INCLUDE);
+ String localDictExcludeColumns =
+
mainTableProperties.get(CarbonCommonConstants.LOCAL_DICTIONARY_EXCLUDE);
+ if (null != localDictIncludeColumns) {
+ listOfDictionaryIncludeColumns =
localDictIncludeColumns.trim().split("\\s*,\\s*");
--- End diff --
what is this split required for?
---
