Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2401#discussion_r198441426
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
 ---
    @@ -615,4 +618,114 @@ object CarbonScalaUtil {
           sparkSession,
           schema)._1.asInstanceOf[Object]
       }
    +
    +  /**
    +   * this method validates the local dictionary columns configurations
    +   *
    +   * @param tableProperties
    +   * @param localDictColumns
    +   */
    +  def validateLocalDictionaryColumns(tableProperties: mutable.Map[String, 
String],
    +      localDictColumns: Seq[String]): Unit = {
    +    var dictIncludeColumns: Seq[String] = Seq[String]()
    +
    +    // check if the duplicate columns are specified in table schema
    +    if (localDictColumns.distinct.lengthCompare(localDictColumns.size) != 
0) {
    +      val duplicateColumns = (dictIncludeColumns ++ localDictColumns)
    --- End diff --
    
    why adding empty Seq here?


---

Reply via email to