Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2408#discussion_r199044379
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomDataMapWriter.java
---
@@ -197,7 +199,7 @@ protected void writeBloomDataMapFile() {
@Override
public void finish() throws IOException {
if (!isWritingFinished()) {
- if (indexBloomFilters.size() > 0) {
+ if (isWriteFromBuilder && indexBloomFilters.size() > 0) {
--- End diff --
I think override `finish` method in `BloomDataMapBuilder.java` is better
than adding a member variable here
---
