GitHub user BJangir opened a pull request:
https://github.com/apache/carbondata/pull/2433
[CARBONDATA-2676]Support local Dictionary for SDK Writer
Currently local dictionary is supported for managed table which is created
using sql .
We it should be supported for SDK Writer also.
This PR contains
a. Interface to supply dictionary threshold & Boolean to enable dictionary.
b. DataLoading flow
**Yet to support**
a. Query Flow of Local dictionary (it will be done when normal table start
supports for same)
b. External Table loading and Query .
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
Existing Interface is not changed added new method
- [ ] Any backward compatibility impacted?
NA
- [ ] Document update required?
NO
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
Added UT
- How it is tested? Please attach test report.
UT is added
- Is it a performance related change? Please attach the performance
test report.
NO
- Any additional information to help reviewers in testing this change.
NO
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BJangir/incubator-carbondata sdk_local_dic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2433.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2433
----
commit 299db85d9d1ddac7425e98075cdd30eac0413773
Author: BJangir <babulaljangir111@...>
Date: 2018-06-30T21:31:05Z
[CARBONDATA-2676]Support local Dictionary for SDK Writer
----
---
