[GitHub] carbondata pull request #2433: [CARBONDATA-2676]Support local Dictionary for...

[ajantha-bhat]

Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2433#discussion_r199370319
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
 ---
    @@ -108,6 +122,20 @@ public TableSchema build() {
           schema.setTableProperties(property);
         }
     
    +    if (isLocalDictionaryEnabled) {
    +      property.put(CarbonCommonConstants.LOCAL_DICTIONARY_ENABLE,
    +          String.valueOf(isLocalDictionaryEnabled));
    +      String localdictionaryThreshold =
    +          localDictionaryThreshold.equalsIgnoreCase("0") ? null : 
localDictionaryThreshold;
    --- End diff --
    
    Need to set default value instead of null ?


---