[GitHub] carbondata pull request #2422: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

[akashrn5]

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2422#discussion_r199402465
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
 ---
    @@ -318,6 +417,11 @@ class AlterTableColumnSchemaGenerator(
               tablePropertiesMap.put(x._1, x._2)
             }
         }
    +
    --- End diff --
    
    mention the reason, why you need to explicitly put these keys into the map


---