[GitHub] carbondata pull request #2422: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

[akashrn5]

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2422#discussion_r199402195
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
 ---
    @@ -299,17 +303,112 @@ class AlterTableColumnSchemaGenerator(
         val columnValidator = CarbonSparkFactory.getCarbonColumnValidator
         columnValidator.validateColumns(allColumns)
     
    +
    --- End diff --
    
    add proper comments to all the changes and methods, and you can move this 
to util class


---