Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2440#discussion_r200022461
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java ---
@@ -50,6 +50,8 @@
protected QueryExecutor queryExecutor;
private InputMetricsStats inputMetricsStats;
+ protected boolean isSearchMode = false;
--- End diff --
It is not so intuitive to understand this, better to add a subclass to
override `close` function---
