Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2440#discussion_r200029615
  
    --- Diff: 
store/core/src/main/java/org/apache/carbondata/store/rest/service/ServiceUtil.java
 ---
    @@ -0,0 +1,107 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.store.rest.service;
    +
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.metadata.datatype.DataTypes;
    +import org.apache.carbondata.core.scan.expression.Expression;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +import org.apache.carbondata.sdk.file.Field;
    +import org.apache.carbondata.store.exception.StoreException;
    +
    +import org.apache.commons.lang.StringUtils;
    +
    +public class ServiceUtil {
    +
    +  public static Expression parseFilter(String filter) {
    +    if (filter == null) {
    +      return null;
    +    }
    +
    +    // TODO parse filter sql to Expression object
    +
    +    return null;
    +  }
    +
    +  public static List<String> prepareSortColumns(
    --- End diff --
    
    please move this into `TableSchemaBuilder` which validate the sort columns


---

Reply via email to