Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2420#discussion_r200151855
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala
 ---
    @@ -255,6 +256,29 @@ object StreamSinkFactory {
           optionsFinal.put("fileheader", 
carbonTable.getCreateOrderColumn(carbonTable.getTableName)
             .asScala.map(_.getColName).mkString(","))
         }
    +    val badRecordsFromLoad = parameters.get("bad_record_path")
    +    val badRecordsFromCreate = 
carbonTable.getTableInfo.getFactTable.getTableProperties
    +      .get("bad_records_path")
    +    val badRecordsPath = if (badRecordsFromLoad.isDefined &&
    --- End diff --
    
    badRecordsFromLoad.isDefined  check not required


---

Reply via email to