Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2420#discussion_r200155277
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java
 ---
    @@ -72,6 +72,28 @@ public CarbonLoadModel build(Map<String, String> 
options, long UUID, String task
           }
           optionsFinal.put("fileheader", Strings.mkString(columns, ","));
         }
    +    String badRecordsFromLoad = options.get("bad_record_path");
    +    String badRecordsFromCreate =
    +        
table.getTableInfo().getFactTable().getTableProperties().get("bad_records_path");
    --- End diff --
    
    Move this logic to common place, related to badrecords, this logic repeated 
so many times


---

Reply via email to