Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200234399
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/BadRecordsLoggerProvider.java
---
@@ -92,13 +90,7 @@ public static String
getBadLogStoreLocation(CarbonDataLoadConfiguration configur
String storeLocation) {
String badLogStoreLocation = (String) configuration
.getDataLoadProperty(CarbonLoadOptionConstants.CARBON_OPTIONS_BAD_RECORD_PATH);
- if (null == badLogStoreLocation) {
- badLogStoreLocation =
-
CarbonProperties.getInstance().getProperty(CarbonCommonConstants.CARBON_BADRECORDS_LOC);
- }
- badLogStoreLocation = badLogStoreLocation + File.separator +
storeLocation;
-
- return badLogStoreLocation;
+ return badLogStoreLocation + File.separator + storeLocation;
--- End diff --
CarbontablePath has path building functions, move all path building there
---
