[GitHub] carbondata pull request #2420: [CARBONDATA-2666] updated rename command so t...

[gvramana]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2420#discussion_r200237355
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java 
---
    @@ -378,8 +377,14 @@ private static void 
getChildDimensionDictionaryDetail(CarbonDimension queryDimen
             ColumnIdentifier columnIdentifier;
             if (null != 
dimension.getColumnSchema().getParentColumnTableRelations() && !dimension
                 .getColumnSchema().getParentColumnTableRelations().isEmpty()) {
    -          dictionarySourceAbsoluteTableIdentifier = 
getTableIdentifierForColumn(dimension,
    -              carbonTable.getAbsoluteTableIdentifier());
    +          RelationIdentifier parentRelationIdentifier =
    --- End diff --
    
    separate to function


---