[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2444#discussion_r200560651
  
    --- Diff: 
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/DefaultMatchMaker.scala
 ---
    @@ -127,8 +126,27 @@ object SelectSelectNoChildDelta extends 
DefaultMatchPattern with PredicateHelper
         }
       }
     
    -  def apply(
    -      subsumer: ModularPlan,
    +  private def isLeftJoinView(subsumer: ModularPlan): Boolean = {
    +    if (subsumer.isInstanceOf[modular.Select]) {
    +      val sel = subsumer.asInstanceOf[modular.Select]
    --- End diff --
    
    better to use match clause to simply the logic in this function


---