Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2444#discussion_r200561054
--- Diff:
datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/ModularRelation.scala
---
@@ -86,10 +87,28 @@ object HarmonizedRelation {
Select(_, _, _, _, _, dim :: Nil, NoFlags, Nil, Nil, _),
NoFlags,
Nil, _) if (dim.isInstanceOf[ModularRelation]) =>
- if (g.outputList
- .forall(col => col.isInstanceOf[AttributeReference] ||
- (col.isInstanceOf[Alias] &&
-
col.asInstanceOf[Alias].child.isInstanceOf[AttributeReference]))) {
+ if (g.outputList.forall(col => {
--- End diff --
better to move the logic out of if condition. and have it better formatted
---
