[GitHub] carbondata pull request #2433: [CARBONDATA-2676]Support local Dictionary for...

[BJangir]

Github user BJangir commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2433#discussion_r200820906
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
 ---
    @@ -108,6 +122,20 @@ public TableSchema build() {
           schema.setTableProperties(property);
         }
     
    +    if (isLocalDictionaryEnabled) {
    +      property.put(CarbonCommonConstants.LOCAL_DICTIONARY_ENABLE,
    +          String.valueOf(isLocalDictionaryEnabled));
    +      String localdictionaryThreshold =
    +          localDictionaryThreshold.equalsIgnoreCase("0") ? null : 
localDictionaryThreshold;
    +      property.put(CarbonCommonConstants.LOCAL_DICTIONARY_THRESHOLD, 
localdictionaryThreshold);
    +      for (int index = 0; index < allColumns.size(); index++) {
    +        ColumnSchema colSchema = allColumns.get(index);
    +        if (colSchema.getDataType() == DataTypes.STRING) {
    +          colSchema.setLocalDictColumn(true);
    --- End diff --
    
    added comment..Done


---