Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2433#discussion_r199382674
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java 
---
    @@ -284,6 +286,28 @@ public CarbonWriterBuilder withBlockSize(int 
blockSize) {
         return this;
       }
     
    +  /**
    +   * @param localDictionaryThreshold is localDictionaryThreshold,default 
is 1000
    +   * @return
    +   */
    +  public CarbonWriterBuilder localDictionaryThreshold(int 
localDictionaryThreshold) {
    +    if (localDictionaryThreshold <= 0) {
    +      throw new IllegalArgumentException("blockSize should be between 
greater than 0");
    +    }
    +    this.localDictionaryThreshold = localDictionaryThreshold;
    +    return this;
    +  }
    +
    +  /**
    +   * @param isLocalDictionaryEnabled enable local dictionary  , default is 
false
    +   * @return updated CarbonWriterBuilder
    +   */
    +  public CarbonWriterBuilder isLocalDictionaryEnabled(boolean 
isLocalDictionaryEnabled) {
    --- End diff --
    
    change the method name to enableLocalDictionary


---

Reply via email to