Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2490#discussion_r202706832
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/AbstractBloomDataMapWriter.java
---
@@ -281,4 +287,13 @@ protected void releaseResouce() {
}
}
+ /**
+ * BloomDataMapBuilder(called when datamap rebuild) is set to true;
+ * BloomDataMapWriter(called when data load) is set to false;
+ *
+ * The reason for this is dict index column is already decoded to
surrogate key when rebuild
+ * but it is still byte array if build datamap when loading
+ */
+ abstract boolean isRebuildProcess();
--- End diff --
It is better to abstract the difference of behavior instead of adding this.
---
