Github user kevinjmh commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2490#discussion_r202883458
  
    --- Diff: 
integration/spark2/src/test/scala/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapSuite.scala
 ---
    @@ -377,6 +377,102 @@ class BloomCoarseGrainDataMapSuite extends QueryTest 
with BeforeAndAfterAll with
         checkQuery("fakeDm", shouldHit = false)
       }
     
    +  test("test create bloom datamap on newly added column") {
    --- End diff --
    
    mostly yes, it depends on the way lucene deals with dictionary column. This 
PR enables to get default value of newly added column by a new result collector 
in `IndexDataMapRebuildRDD` and other codes are worked for getting surrogate 
value of dictionary column relying  on PR2425


---

Reply via email to