GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2605
[CARBONDATA-2585] Fix local dictionary for both table level and system
level property based on priority
### What are the changes
Added a System level Property for local dictionary Support.
Property 'carbon.local.dictionary.enable' can be set to true/false to
enable/disable local dictionary at system level.
If table level property LOCAL_DICTIONARY_ENABLE is configured, then Local
Dictionary generation will be considered based on the table level property
irrespective of the system level property.
If not, then the System level property 'carbon.local.dictionary.enable'
value will be considered for local dictionary generation.
By default, both 'carbon.local.dictionary.enable' and
LOCAL_DICTIONARY_ENABLE are false (Local Dictionary generation is disabled).
- [ ] Any interfaces changed?
NA
- [ ] Any backward compatibility impacted?
NA
- [ ] Document update required?
Yes
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
Test cases are added
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akashrn5/incubator-carbondata
local_system_level
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2605
----
commit bda5d813ecd3c4a498c9da9d30bf0ba274ea5915
Author: akashrn5 <akashnilugal@...>
Date: 2018-08-02T14:50:48Z
fix local dictionary for both table level and system level property based
on priority
----
---
