Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2605#discussion_r207282883
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
 ---
    @@ -378,19 +376,65 @@ class AlterTableColumnSchemaGenerator(
           }
         }
     
    +    var isLocalDictEnabledForMainTable = tableSchema.getTableProperties
    +      .get(CarbonCommonConstants.LOCAL_DICTIONARY_ENABLE)
    +    if (null == isLocalDictEnabledForMainTable) {
    +      isLocalDictEnabledForMainTable = CarbonProperties.getInstance()
    +        .getProperty(CarbonCommonConstants.LOCAL_DICTIONARY_SYSTEM_ENABLE,
    +          CarbonCommonConstants.LOCAL_DICTIONARY_SYSTEM_ENABLE_DEFAULT)
    +    }
    +
    +    val alterMutableTblProperties: scala.collection.mutable.Map[String, 
String] = mutable
    +      .Map(alterTableModel.tableProperties.toSeq: _*)
    --- End diff --
    
    no need for null check, beacuse we are always adding sort columns


---

Reply via email to