Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2605#discussion_r208111973
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -931,6 +931,11 @@
*/
public static final String LOCAL_DICTIONARY_ENABLE_DEFAULT = "false";
+ /**
+ * System property to enable or disable local dictionary generation
+ */
+ public static final String LOCAL_DICTIONARY_SYSTEM_ENABLE =
"carbon.local.dictionary.enable";
--- End diff --
If we already have table level property, why this system level property is
required? I think too many system property will make CarbonData complex to use
and configure
---
