Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2654#discussion_r214092679
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/SortStepRowHandler.java
---
@@ -240,8 +258,44 @@ public IntermediateSortTempRow
readWithNoSortFieldConvert(
return new IntermediateSortTempRow(dictSortDims,
noDictSortDims,measure);
}
+ /**
+ * Read the data from the stream
+ *
+ * @param inputStream
+ * @param idx
+ * @return
+ * @throws IOException
+ */
+ private Object readDataFromStream(DataInputStream inputStream, int idx)
throws IOException {
--- End diff --
is it refactor code ?? I think same code is also present for measures, can
u please check and combine
---
