Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2654#discussion_r214338168
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/SortStepRowHandler.java
---
@@ -375,6 +454,47 @@ public void
writeRawRowAsIntermediateSortTempRowToOutputStream(Object[] row,
outputStream.write(rowBuffer.array(), 0, packSize);
}
+ /**
+ * Write the data to stream
+ *
+ * @param data
+ * @param outputStream
+ * @param idx
+ * @throws IOException
+ */
+ private void writeDataToStream(Object data, DataOutputStream
outputStream, int idx)
+ throws IOException {
+ DataType dataType = noDicSortDataTypes[idx];
+ if (null == data) {
+ outputStream.writeBoolean(false);
+ return;
--- End diff --
do not use return statement instead use the if else block wisely
---
