Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2644#discussion_r214310465
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonMetadataUtil.java ---
    @@ -96,14 +96,35 @@ private static FileFooter3 
getFileFooter3(List<BlockletInfo3> infoList,
         return footer;
       }
     
    -  public static BlockletIndex getBlockletIndex(
    -      org.apache.carbondata.core.metadata.blocklet.index.BlockletIndex 
info) {
    +  public static 
org.apache.carbondata.core.metadata.blocklet.index.BlockletMinMaxIndex
    +      convertExternalMinMaxIndex(BlockletMinMaxIndex minMaxIndex) {
    --- End diff --
    
    please add a method comment to explain what is meaning of 
convertExternalMinMaxIndex


---

Reply via email to