Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2644#discussion_r214877247
  
    --- Diff: 
streaming/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordWriter.java
 ---
    @@ -212,9 +213,13 @@ private void initializeAtFirstRow() throws 
IOException, InterruptedException {
                 byte[] col = (byte[]) columnValue;
                 output.writeShort(col.length);
                 output.writeBytes(col);
    +            output.dimStatsCollectors[dimCount].update(col);
               } else {
                 output.writeInt((int) columnValue);
    +            
output.dimStatsCollectors[dimCount].update(ByteUtil.toBytes((int) columnValue));
    --- End diff --
    
    I think dictionary case never come for streaming. Anyway please use 
`output.dimStatsCollectors[dimCount].update((int) columnValue)` instead of 
converting binary


---

Reply via email to