Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2654#discussion_r214356896
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java
---
@@ -239,12 +239,25 @@ private boolean isEncodedWithMeta(DataChunk2
pageMetadata) {
protected DimensionColumnPage decodeDimension(DimensionRawColumnChunk
rawColumnPage,
ByteBuffer pageData, DataChunk2 pageMetadata, int offset)
throws IOException, MemoryException {
+ List<Encoding> encodings = pageMetadata.getEncoders();
if (isEncodedWithMeta(pageMetadata)) {
ColumnPage decodedPage = decodeDimensionByMeta(pageMetadata,
pageData, offset,
null != rawColumnPage.getLocalDictionary());
decodedPage.setNullBits(QueryUtil.getNullBitSet(pageMetadata.presence));
- return new ColumnPageWrapper(decodedPage,
rawColumnPage.getLocalDictionary(),
- isEncodedWithAdaptiveMeta(pageMetadata));
+ int[] invertedIndexes = new int[0];
--- End diff --
add a comment to explain that this scenario is to handle no dictionary
primitive type columns where inverted index can be created on row id's during
data load
---
