Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2704#discussion_r216906796
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/CarbonMetadata.java ---
@@ -143,7 +143,7 @@ public CarbonDimension
getCarbonDimensionBasedOnColIdentifier(CarbonTable carbon
List<CarbonDimension> listOfCarbonDims =
carbonTable.getDimensionByTableName(carbonTable.getTableName());
for (CarbonDimension dimension : listOfCarbonDims) {
- if (dimension.getColumnId().equals(columnIdentifier)) {
+ if (dimension.getColumnId().equalsIgnoreCase(columnIdentifier)) {
--- End diff --
Will the comparison for columnId still need case insensitive?
If it is yes, I'd suggest you to leave comments for this (for old store
before version XXX).
---
