Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2704#discussion_r217020324
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/CarbonMetadata.java ---
    @@ -143,7 +143,7 @@ public CarbonDimension 
getCarbonDimensionBasedOnColIdentifier(CarbonTable carbon
         List<CarbonDimension> listOfCarbonDims =
             carbonTable.getDimensionByTableName(carbonTable.getTableName());
         for (CarbonDimension dimension : listOfCarbonDims) {
    -      if (dimension.getColumnId().equals(columnIdentifier)) {
    +      if (dimension.getColumnId().equalsIgnoreCase(columnIdentifier)) {
    --- End diff --
    
    this is the case for non-transactional flow. It uses column name for 
columnid as well. It is the safest way to do the check and there would not be 
any side effects on it,


---

Reply via email to