[GitHub] carbondata pull request #2725: [CARBONDATA-2942] Add read and write support ...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2725#discussion_r218062180
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
 ---
    @@ -122,11 +122,11 @@ public boolean isScanRequired(DataRefNode dataBlock) {
             bitSet = ((ImplicitColumnFilterExecutor) filterExecuter)
                 .isFilterValuesPresentInBlockOrBlocklet(
                     dataBlock.getColumnsMaxValue(),
    -                dataBlock.getColumnsMinValue(), blockletId);
    +                dataBlock.getColumnsMinValue(), blockletId, 
dataBlock.isMinMaxSet());
           } else {
             bitSet = this.filterExecuter
                 .isScanRequired(dataBlock.getColumnsMaxValue(),
    -                dataBlock.getColumnsMinValue());
    +                dataBlock.getColumnsMinValue(), dataBlock.isMinMaxSet());
    --- End diff --
    
    Please use the minaxflags from the current footer and do the scan require 
check


---