Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2725#discussion_r218139444
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
 ---
    @@ -108,10 +108,13 @@ public BitSetGroup 
applyFilter(RawBlockletColumnChunks rawBlockletColumnChunks,
           BitSetGroup bitSetGroup = new 
BitSetGroup(dimensionRawColumnChunk.getPagesCount());
           filterValues = dimColumnExecuterInfo.getFilterKeys();
           boolean isDecoded = false;
    +      boolean isMinMaxSetForFilterDimension =
    +          rawBlockletColumnChunks.getDataBlock().isMinMaxSet()[chunkIndex];
           for (int i = 0; i < dimensionRawColumnChunk.getPagesCount(); i++) {
             if (dimensionRawColumnChunk.getMaxValues() != null) {
    -          if (isScanRequired(dimensionRawColumnChunk.getMaxValues()[i],
    -              dimensionRawColumnChunk.getMinValues()[i], 
dimColumnExecuterInfo.getFilterKeys())) {
    +          if (!isMinMaxSetForFilterDimension || isScanRequired(
    --- End diff --
    
    ok


---

Reply via email to