[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2726#discussion_r218104702
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java
 ---
    @@ -93,7 +93,22 @@ public double getDouble(int rowId) {
     
       @Override
       public float getFloat(int rowId) {
    -    throw new UnsupportedOperationException("internal error");
    +    DataType dataType = columnPage.getDataType();
    --- End diff --
    
    Just call `getDouble(rowId)` from this method and then typecast it. No need 
to duplicate the code


---