Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2726#discussion_r218109409
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java
---
@@ -139,15 +139,15 @@ public void encode(int rowId, long value) {
@Override
public void encode(int rowId, float value) {
if (targetDataType == DataTypes.BYTE) {
- encodedPage.putByte(rowId, (byte) (value * factor));
+ encodedPage.putByte(rowId, (byte) (value * (float) factor));
--- End diff --
don't typecast it every time, take another float variable at class level
---
