Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220802829
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -101,6 +101,20 @@ public CarbonReaderBuilder
withHadoopConf(Configuration conf) {
return this;
}
+
+ public CarbonReaderBuilder withHadoopConf(String[] args) {
+ Configuration configuration = new Configuration();
--- End diff --
My comment is the same, we should not replace entire conf object every
time. Change this method as withHadoopConf(String key, String value) and
update property to a class level hadoopConfiguraiton variable.
---
