Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2738#discussion_r220774262
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java 
---
    @@ -101,6 +101,20 @@ public CarbonReaderBuilder 
withHadoopConf(Configuration conf) {
         return this;
       }
     
    +
    +  public CarbonReaderBuilder withHadoopConf(String[] args) {
    --- End diff --
    
    yeah. but java layer don't support withHadoopConf(String key, String 
value), I think we should both support in java and c layer. and config(key: 
String, value: String) is better than withHadoopConf(String key, String value)


---

Reply via email to