Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r225826457
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageDecoder.java
---
@@ -29,6 +31,12 @@
*/
ColumnPage decode(byte[] input, int offset, int length) throws
MemoryException, IOException;
+ /**
+ * Apply decoding algorithm on input byte array and fill the vector
here.
+ */
+ ColumnPage decodeAndFillVector(byte[] input, int offset, int length,
ColumnVectorInfo vectorInfo,
--- End diff --
decodeAndFillVector return type can be void as ColumnPage returned from
decodeAndFillVector will not be used
---
