Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r225828205
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/FixedLengthDimensionColumnPage.java
---
@@ -46,10 +46,37 @@ public FixedLengthDimensionColumnPage(byte[] dataChunk,
int[] invertedIndex,
dataChunk.length;
dataChunkStore = DimensionChunkStoreFactory.INSTANCE
.getDimensionChunkStore(columnValueSize, isExplicitSorted,
numberOfRows, totalSize,
- DimensionStoreType.FIXED_LENGTH, null);
+ DimensionStoreType.FIXED_LENGTH, null, false);
dataChunkStore.putArray(invertedIndex, invertedIndexReverse,
dataChunk);
}
+ /**
+ * Constructor
+ *
+ * @param dataChunk data chunk
+ * @param invertedIndex inverted index
+ * @param invertedIndexReverse reverse inverted index
+ * @param numberOfRows number of rows
+ * @param columnValueSize size of each column value
+ * @param vectorInfo vector to be filled with decoded column
page.
+ */
+ public FixedLengthDimensionColumnPage(byte[] dataChunk, int[]
invertedIndex,
--- End diff --
For direct vector filler this instance creation is not required as it will
not be used.
---
