Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2715#discussion_r226274512
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala
---
@@ -42,6 +44,112 @@ case class Rcd(booleanField: Boolean, shortField:
Short, intField: Int, bigintFi
dateField: String, charField: String, floatField: Float,
stringDictField: String,
stringSortField: String, stringLocalDictField: String,
longStringField: String)
+/**
+ * This compressor actually will not compress or decompress anything.
+ * It is used for test case of specifying customized compressor.
+ */
+class CustomizeCompressor extends Compressor {
+ override def getName: String =
"org.apache.carbondata.integration.spark.testsuite.dataload.CustomizeCompressor"
--- End diff --
We no need to maintain the relationship between shortname and class name.
user mentions short name in the implemented class and keeps the jar in
classpath. Carbondata loads all classes which are implementing compressor class
and loads the class and gets the shortname from that class.
So user only should give shortname in table properties and we store only
shortname in thrift as well. This is just like spark datasource , please go
through it once. It would be simple for user if we provide short name.
---
