Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2715#discussion_r227235560
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala
 ---
    @@ -42,6 +44,112 @@ case class Rcd(booleanField: Boolean, shortField: 
Short, intField: Int, bigintFi
         dateField: String, charField: String, floatField: Float, 
stringDictField: String,
         stringSortField: String, stringLocalDictField: String, 
longStringField: String)
     
    +/**
    + * This compressor actually will not compress or decompress anything.
    + * It is used for test case of specifying customized compressor.
    + */
    +class CustomizeCompressor extends Compressor {
    +  override def getName: String = 
"org.apache.carbondata.integration.spark.testsuite.dataload.CustomizeCompressor"
    --- End diff --
    
    I am not sure, what you are referring, but I am referring spark datasource 
(fileformat) design. For example, while creating carbon table we just mention 
`using carbon` but never mention whole implementation class name. It also saves 
only the shortname `carbon` in its metadata, not the whole class name. It can 
get the whole class name from implementation classes of `FileFormat`. 


---

Reply via email to