Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2823#discussion_r226550593
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaFloatingCodec.java
---
@@ -225,6 +238,71 @@ public double decodeDouble(long value) {
return (max - value) / factor;
}
+ @Override
+ public void decodeAndFillVector(ColumnPage columnPage,
ColumnVectorInfo vectorInfo) {
+ CarbonColumnVector vector = vectorInfo.vector;
+ BitSet nullBits = columnPage.getNullBits();
+ DataType type = columnPage.getDataType();
+ int pageSize = columnPage.getPageSize();
+ BitSet deletedRows = vectorInfo.deletedRows;
+ DataType dataType = vector.getType();
--- End diff --
What's the relationship between `columnPage.getDataType()` and
`vector.getType()`?
---
