Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2823#discussion_r226547597
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java
---
@@ -91,6 +95,31 @@ public void putArray(final int[] invertedIndex, final
int[] invertedIndexReverse
}
}
+ @Override
+ public void fillVector(int[] invertedIndex, int[] invertedIndexReverse,
byte[] data,
+ ColumnVectorInfo vectorInfo) {
+ this.invertedIndexReverse = invertedIndex;
+
+ // as first position will be start from 2 byte as data is stored first
in the memory block
--- End diff --
please fix the comment here since it is not always 2 bytes.
---
