Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2820#discussion_r226866881
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
 ---
    @@ -148,6 +148,61 @@ private void ifDefaultValueMatchesFilter() {
         return bitSet;
       }
     
    +  @Override
    +  public BitSet prunePages(RawBlockletColumnChunks rawBlockletColumnChunks)
    +      throws FilterUnsupportedException, IOException {
    --- End diff --
    
    Yes, lot of code is duplicated across all range filters, maybe we should 
combine some of the classes. We can do this refactoring in another PR.


---

Reply via email to