Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2820#discussion_r226905099
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
 ---
    @@ -143,6 +144,40 @@ public BitSetGroup applyFilter(RawBlockletColumnChunks 
rawBlockletColumnChunks,
         return null;
       }
     
    +  @Override
    +  public BitSet prunePages(RawBlockletColumnChunks rawBlockletColumnChunks)
    +      throws FilterUnsupportedException, IOException {
    +    if (isDimensionPresentInCurrentBlock) {
    +      int chunkIndex = 
segmentProperties.getDimensionOrdinalToChunkMapping()
    +          .get(dimColEvaluatorInfo.getColumnIndex());
    +      if (null == 
rawBlockletColumnChunks.getDimensionRawColumnChunks()[chunkIndex]) {
    --- End diff --
    
    May we can take note of this point and add the page count in the blocklet 
metadata to avoid reading of dimension chunks for Exclude filter case


---

Reply via email to