[GitHub] carbondata pull request #2823: [CARBONDATA-3015] Support Lazy load in carbon...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2823#discussion_r226867910
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaFloatingCodec.java
 ---
    @@ -225,6 +238,71 @@ public double decodeDouble(long value) {
           return (max - value) / factor;
         }
     
    +    @Override
    +    public void decodeAndFillVector(ColumnPage columnPage, 
ColumnVectorInfo vectorInfo) {
    +      CarbonColumnVector vector = vectorInfo.vector;
    +      BitSet nullBits = columnPage.getNullBits();
    +      DataType type = columnPage.getDataType();
    +      int pageSize = columnPage.getPageSize();
    +      BitSet deletedRows = vectorInfo.deletedRows;
    +      DataType dataType = vector.getType();
    --- End diff --
    
    column page datatype is adpative datatype and vector datatype is actual 
type. I will rename them


---