Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2841#discussion_r227339904
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java 
---
    @@ -124,8 +116,21 @@ private synchronized MemoryBlock 
allocateMemory(MemoryType memoryType, String ta
                 + "Bytes");
           }
           return allocate;
    +    } else {
    +      MemoryBlock allocate = 
MemoryAllocator.HEAP.allocate(memoryRequested);
    --- End diff --
    
    Its not actually fall back once offheap memory is available it will switch 
to offheap ...depends on offheap memory , i will add debug log 


---

Reply via email to