Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2841#discussion_r228692174
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -77,21 +77,12 @@
if (takenSize < defaultSize) {
takenSize = defaultSize;
LOGGER.warn(String.format(
- "It is not recommended to set unsafe working memory size less
than %sMB,"
+ "It is not recommended to set offheap working memory size less
than %sMB,"
+ " so setting default value to %d",
CarbonCommonConstants.UNSAFE_WORKING_MEMORY_IN_MB_DEFAULT,
defaultSize));
}
takenSize = takenSize * 1024 * 1024;
} else {
- long maxMemory = Runtime.getRuntime().maxMemory() * 60 / 100;
- if (takenSize == 0L) {
- takenSize = maxMemory;
- } else {
- takenSize = takenSize * 1024 * 1024;
- if (takenSize > maxMemory) {
- takenSize = maxMemory;
- }
- }
--- End diff --
Please add a comment why memory limit is not required to take for ONHEAP
---
