[GitHub] carbondata pull request #2837: [CARBONDATA-3000] Provide C++ interface for w...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2837#discussion_r228715343
  
    --- Diff: store/CSDK/src/CarbonReader.h ---
    @@ -40,6 +40,19 @@ class CarbonReader {
          */
         jobject carbonReaderObject;
     
    +    /**
    +     * check whether has called builder
    +     *
    +     * @return true or throw exception
    +     */
    +    bool checkBuilder();
    +
    +    /**
    +     * check reader and whether has called build
    --- End diff --
    
    can you improve this comment, suggest you write like "Return true if ...."


---